Update deprecated usage of attribute_changed? in callbacks (#2929)

Co-authored-by: Aleksandar N. Kostadinov <akostadi@redhat.com>

Author: josemigallas

app/events/oidc/proxy_changed_event.rb

@@ -21,6 +21,8 @@ def self.create(proxy)
   def self.valid?(proxy)
     service = proxy.try(:service)
     return unless service
-    service.backend_version.oauth? || service.backend_version_change&.include?('oauth')
+
+    # TODO: second assertion is probably useless, or not. Revisit this in the future once we've seen this is safe. See https://github.com/3scale/porta/pull/2929/files#r846345372
+    service.backend_version.oauth? || service.backend_version_change_to_be_saved&.include?('oauth') || service.saved_change_to_backend_version&.include?('oauth')
   end
 end

app/lib/authentication/by_password.rb

@@ -39,7 +39,7 @@ def transparently_migrate_password(unencrypted_password)
       end
 
       def just_changed_password?
-        previous_changes.key?('password_digest') || super
+        saved_change_to_password_digest? || super
       end
 
       private
@@ -113,7 +113,7 @@ def password_required?
       end
 
       def just_changed_password?
-        previous_changes.key?('crypted_password')
+        saved_change_to_crypted_password?
       end
 
       private

app/lib/backend/model_extensions/cinstance.rb

@@ -44,9 +44,9 @@ def delete_backend_application
       end
 
       def update_backend_user_key_to_application_id_mapping
-        user_key_was, current_user_key = previous_changes[:user_key]
+        user_key_was, current_user_key = saved_change_to_user_key
 
-        if previously_changed?(:user_key) && service.id.present? && user_key_was.present?
+        if saved_change_to_user_key? && service.id.present? && user_key_was.present?
           ThreeScale::Core::Application.delete_id_by_key(service.backend_id, user_key_was)
         end
 
@@ -78,8 +78,8 @@ def set_application_id
       end
 
       def update_provider_backend_service_if_user_key_changed
-        if previously_changed?(:user_key)
-          user_key_was, user_key = previous_changes[:user_key]
+        if saved_change_to_user_key?
+          user_key_was, user_key = saved_change_to_user_key
 
           if user_account && user_account.provider? && user_key_was.present? && user_account.services.present?
             ThreeScale::Core::Service.change_provider_key!(user_key_was, user_key)

app/lib/backend/model_extensions/provider.rb

@@ -4,12 +4,11 @@ module Provider
       extend ActiveSupport::Concern
 
       included do
-        after_commit :update_backend_default_service_id, :if => :provider?, :unless => :master?
+        after_commit :update_backend_default_service_id, if: -> { provider? && saved_change_to_default_service_id? }, unless: :master?
       end
 
       def update_backend_default_service_id
         return if destroyed?
-        return unless previously_changed?(:default_service_id)
         services.default.update_backend_service
       end
     end

app/lib/backend/model_extensions/usage_limit.rb

@@ -27,7 +27,7 @@ def update_backend_usage_limit
 
       def delete_backend_usage_limit
         if plan_and_service?
-          original_period = previously_changed?(:period) ? period_previous_change.compact.first : period
+          original_period = saved_change_to_period? ? saved_change_to_period.compact.first : period
           ThreeScale::Core::UsageLimit.delete(service.backend_id, plan.backend_id, metric_id, original_period)
         end
 

app/lib/permalink_fu.rb

@@ -25,7 +25,8 @@ def permalink(attr_name, options = {})
   private
 
   def create_unique_permalink
-    return if permalink.present? && !permalink_changed?
+    return if permalink.present? && !will_save_change_to_permalink?
+
     base_permalink = build_permalink_from_attribute
     count = where_match_permalink_with_conditions(base_permalink).count
     self.permalink = count.positive? ? "#{base_permalink}-#{count + 1}" : base_permalink

app/lib/redhat_customer_portal_support.rb

@@ -14,18 +14,18 @@ def redhat_customer_authentication_provider
   end
 
   def redhat_account_recently_verified?
-    extra_fields_change = previous_changes['extra_fields']
+    extra_fields_change = saved_change_to_extra_fields
 
     return false unless extra_fields_change
 
-    verified_by_was = extra_fields_change.first['red_hat_account_verified_by']
-    verified_by = extra_fields_change.last['red_hat_account_verified_by']
+    verified_by_was = extra_fields_change.first[:red_hat_account_verified_by]
+    verified_by = extra_fields_change.last[:red_hat_account_verified_by]
 
     verified_by_was.blank? && verified_by.present?
   end
 
   def recently_suspended?
-    previous_changes['state'] && suspended?
+    saved_change_to_attribute(:state) && suspended?
   end
 
   private

app/models/account/billing.rb

@@ -5,7 +5,7 @@ module Account::Billing
 
   included do
     has_many :invoices, :foreign_key => 'buyer_account_id'
-    after_save :update_invoices_vat_rates
+    after_save :update_invoices_vat_rates, if: :saved_change_to_vat_rate?
     before_destroy :check_unresolved_invoices
   end
 
@@ -33,9 +33,7 @@ def billable_contracts_with_trial_period_expired(now)
   protected
 
   def update_invoices_vat_rates
-    if previously_changed?(:vat_rate) || changes.key?(:vat_rate)
-      self.invoices.not_frozen.reorder('').update_all(:vat_rate => self.vat_rate)
-    end
+    invoices.not_frozen.reorder('').update_all(vat_rate: vat_rate)
   end
 
   # Will prevent the buyer from destroying if there are unresolved

app/models/account/credit_card.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 # TODO: will become a CreditCard model by itself soon
-module Account::CreditCard
+module Account::CreditCard # rubocop:disable Metrics/ModuleLength(RuboCop)
   extend ActiveSupport::Concern
 
   included do
@@ -113,9 +115,9 @@ def unstore_credit_card!
   end
 
   def notify_credit_card_change
-    credit_card_changes = previous_changes.slice(credit_card_stored_attribute,
-                                     :credit_card_partial_number,
-                                     :credit_card_expires_on)
+    credit_card_changes = saved_changes.slice(credit_card_stored_attribute,
+                                              :credit_card_partial_number,
+                                              :credit_card_expires_on)
 
     return unless credit_card_changes.present?
 

app/models/account/provider_domains.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-module Account::ProviderDomains
+module Account::ProviderDomains # rubocop:disable Metrics/ModuleLength
   extend ActiveSupport::Concern
 
-  included do
+  included do # rubocop:disable Metrics/BlockLength
     include ThreeScale::DomainSubstitution::Account
 
     with_options :if => :validate_domains? do |provider|
@@ -78,7 +78,7 @@ def same_domain(domain)
   end
 
   def domains_changed?
-    attribute_changed?(:domain) || attribute_changed?(:self_domain)
+    saved_change_to_domain? || saved_change_to_self_domain?
   end
 
   def publish_domain_events