Fix tests by further removing dead code

Author: mayorova

app/services/reports/data_export_service.rb

@@ -1,3 +1,5 @@
+require 'zip'
+
 class Reports::DataExportService
   attr_reader :provider, :type, :period
 

app/views/notification_mailer/post_created.html.slim

@@ -7,5 +7,3 @@ p
 - else
   p
     | Anonymous user has posted a new message in your forum
-
-p= link_to 'View new forum post', forum_topic_url(@post.topic, host: @provider_account.external_domain)

app/views/notification_mailer/post_created.text.erb

@@ -4,4 +4,3 @@ Dear <%= @receiver.informal_name %>,
 <% else %>
 Anonymous user has posted a new message in your forum
 <% end %>
-To view new forum post, follow this link <%= forum_topic_url(@post.topic, host: @provider_account.external_domain) %>

app/views/topic_mailer/new_post.text.erb

@@ -5,6 +5,4 @@ A new post has been posted in the thread <%= h @post.topic.title %>
 Post:
 <%= truncate h(@post.body), :length => 300 %>
 
-Read more: <%= forum_topic_url(:id => @post.topic, :host => @domain) -%>
-
 The 3SCALE Developer Team

features/step_definitions/navigation_steps.rb

@@ -9,17 +9,6 @@
   click_link href: admin_buyers_accounts_path
 end
 
-# TODO: THREESCALE-8033 Remove this step as it's no longer in use.
-When "I navigate to a topic in the forum of {forum}" do |forum|
-  visit forum_path
-  click_link forum.topics.first.title
-end
-
-When "I should not see forum" do
-  visit forum_path
-  assert_text "Page not found"
-end
-
 When "I navigate to the {application} of the partner {string}" do |app, partner|
   click_link(href: admin_buyers_accounts_path)
   click_link partner

features/support/paths.rb

@@ -122,22 +122,6 @@ def path_to(page_name, *args) # rubocop:disable Metrics/AbcSize, Metrics/Cycloma
 
       admin_messages_trash_path(message)
 
-    #
-    # Forum
-    #
-    when 'forum settings',
-         'the forum settings page'
-      edit_admin_site_forum_path
-
-    when 'the forum page'
-      forum_path
-    when 'the new topic page'
-      new_forum_topic_path
-    when /^the "([^"]*)" topic page$/
-      forum_topic_path(Topic.find_by_title!($1))
-    when 'the forum subscriptions page'
-      forum_subscriptions_path
-
     #
     # Logged in
     #
@@ -532,22 +516,6 @@ def path_to(page_name, *args) # rubocop:disable Metrics/AbcSize, Metrics/Cycloma
     when /^the data exports page$/
       new_admin_data_exports_path
 
-    #
-    # Forum admin
-    #
-    when 'the admin portal forum page'
-      admin_forum_path
-    when 'the admin portal new topic page'
-      new_admin_forum_topic_path
-    when /^the admin portal "([^"]*)" topic page$/
-      admin_forum_topic_path(Topic.find_by_title!($1))
-    when /^the admin portal edit "([^"]*)" topic page$/
-      edit_admin_forum_topic_path(Topic.find_by_title!($1))
-    when 'the admin portal forum categories page'
-      admin_forum_categories_path
-    when 'the admin portal new forum category page'
-      new_admin_forum_category_path
-
     #
     # Site settings
     #

lib/developer_portal/app/views/developer_portal/dashboards/components/_latest_forum_posts.html.erb

@@ -1,16 +1,5 @@
 <% if site_account.forum && site_account.forum.posts.size > 0 %>
   <div class="dashboard_card round">
     <h3>Latest Forum Activity</h3>
-
-    <ul class="latest-forum-posts">
-      <%- site_account.forum.posts.order(created_at: :desc).limit(5).each do |post| -%>
-        <li>
-          New
-          <%= link_to 'post',
-              main_app.forum_topic_path(post.topic, :anchor => "post_#{post.id}") %>
-          on topic <%= link_to post.topic.title, main_app.forum_topic_path(post.topic) %>
-        </li>
-      <%- end -%>
-    </ul>
   </div>
 <%- end -%>

lib/developer_portal/lib/liquid/drops/post.rb

@@ -24,7 +24,7 @@ def created_at
 
       desc "The URL of this post within its topic."
       def url
-        System::UrlHelpers.system_url_helpers.forum_topic_path(@model.topic, anchor: "post_#{@model.id}")
+        ""
       end
     end
   end

lib/developer_portal/lib/liquid/drops/topic.rb

@@ -10,7 +10,7 @@ def title
       end
 
       def url
-        System::UrlHelpers.system_url_helpers.forum_topic_path(@model)
+        ''
       end
     end
   end

test/integration/sessions_test.rb

@@ -59,8 +59,7 @@ def setup
       format: :xml,
       provider_key: @provider.api_key,
       user_id: user_id,
-      username: user.username,
-      redirect_url: forum_path(host: @provider.internal_domain)
+      username: user.username
     }
 
     assert_response :created
@@ -117,7 +116,7 @@ def setup
 
     host! @provider.internal_domain
 
-    get developer_portal.create_session_url(username: user.username, password: 'superSecret1234#', redirect_url: forum_url(host: @provider.internal_domain))
+    get developer_portal.create_session_url(username: user.username, password: 'superSecret1234#', redirect_url: developer_portal.login_url(host: @provider.internal_domain))
     follow_redirect!
 
     assert_equal root_path, path
@@ -131,10 +130,10 @@ def setup
 
     host! @provider.internal_domain
 
-    get developer_portal.create_session_url(token: 'yabadabado', expires_at: '2016', redirect_url: forum_url(host: @provider.internal_domain))
+    get developer_portal.create_session_url(token: 'yabadabado', expires_at: '2016', redirect_url: developer_portal.login_url(host: @provider.internal_domain))
     follow_redirect!
 
-    assert_equal forum_path, path
+    assert_equal developer_portal.login_path, path
   end
 
   test 'passing redirect_to to login form' do